Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(badge): add xxsmall size to ionic theme #29570

Merged
merged 7 commits into from
May 31, 2024
Merged

feat(badge): add xxsmall size to ionic theme #29570

merged 7 commits into from
May 31, 2024

Conversation

thetaPC
Copy link
Contributor

@thetaPC thetaPC commented May 30, 2024

Issue number: internal


What is the current behavior?

Badge does not have a xxsmall size.

What is the new behavior?

  • Added the xxsmall size for the ionic theme.
  • Added tests.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview

Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 3:03pm

@thetaPC thetaPC marked this pull request as ready for review May 30, 2024 18:04
@thetaPC thetaPC requested a review from a team as a code owner May 30, 2024 18:04
@thetaPC thetaPC changed the title feat(badge): add 2xsmall size to ionic theme feat(badge): add xxsmall size to ionic theme May 30, 2024
thetaPC and others added 2 commits May 30, 2024 16:29
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
@thetaPC thetaPC merged commit 7d4a704 into next May 31, 2024
46 checks passed
@thetaPC thetaPC deleted the ROU-10723 branch May 31, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants