Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(badge): add soft to the ionic theme #29573

Merged
merged 10 commits into from
May 31, 2024
Merged

feat(badge): add soft to the ionic theme #29573

merged 10 commits into from
May 31, 2024

Conversation

thetaPC
Copy link
Contributor

@thetaPC thetaPC commented May 30, 2024

Issue number: internal


What is the current behavior?

Badge does not have a soft shape.

What is the new behavior?

  • Added the soft shape for the ionic theme.
  • Added the shape prop.
  • Added tests.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview

Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 6:06pm

@github-actions github-actions bot added package: angular @ionic/angular package package: vue @ionic/vue package labels May 30, 2024
@thetaPC thetaPC marked this pull request as ready for review May 30, 2024 23:49
@thetaPC thetaPC requested a review from a team as a code owner May 30, 2024 23:49
core/src/components/badge/badge.ionic.scss Outdated Show resolved Hide resolved
core/src/components/badge/test/shape/badge.e2e.ts Outdated Show resolved Hide resolved
thetaPC and others added 2 commits May 31, 2024 09:20
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
@thetaPC thetaPC merged commit 777521f into next May 31, 2024
46 checks passed
@thetaPC thetaPC deleted the ROU-10730 branch May 31, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants