Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ionNavBar,ionHeaderBar): use declarative syntax #788

Closed
wants to merge 1 commit into from

Conversation

ajoslin
Copy link
Contributor

@ajoslin ajoslin commented Mar 14, 2014

Closes #777
Closes #596
Closes #477

New Documentation:

Also: test count up to 324 :-)

BREAKING CHANGE:

navBar is majorly different.  Manually write this when changelog is
released.  Add link to docs.
@ajoslin
Copy link
Contributor Author

ajoslin commented Mar 14, 2014

There's a lot here to read.

The only code that really needs review, however, is these:

@ajoslin
Copy link
Contributor Author

ajoslin commented Mar 14, 2014

Landed via bfcfae3

@ajoslin ajoslin closed this Mar 14, 2014
@rvanbaalen
Copy link

@ajoslin Ok, nice.. but this is quite the breaking change you introduced here. Any comments on how to transition from the old code to this?

For example, I now have $scope.leftButtons defined in my controllers to generate left buttons in my header. But that doesn't seem to work anymore?

@ajoslin
Copy link
Contributor Author

ajoslin commented Mar 15, 2014

We will be pushing out a new release with this hopefully early in this coming week, with a migration guide and detailed documentation. Until then, the nightly branch is in a state of serious flux.

For now, check this out: http://ajoslin.github.io/docs/nightly/api/directive/ionNavBar/

Even that doc page is in a state of huge flux until the release, though.

@ajoslin ajoslin deleted the navbar-declarative branch April 16, 2014 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants