fix(toast): toast animation with status bar padding #8685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manucorporat
force-pushed
the
fix-toast-animation
branch
from
8e0ce03
to
bc03310
Compare
brandyscarney
requested changes
Oct 18, 2016
| // top | ||
| // by default, it is -100% hidden (above the screen) | ||
| // so move from that to 10px below top: 0px; | ||
| wrapper.fromTo('translateY', '-100%', `${10}px`); | ||
| if (opts.statusBarPadding) { | ||
| padding += 20; |
There was a problem hiding this comment.
We shouldn't hardcode the status bar padding at 20, since it can be changed via Sass variable here: https://github.com/driftyco/ionic/blob/master/src/platform/cordova.scss#L7
and with this issue added support per mode: #8712
|
|
|
Can you fix the merge conflicts and get this working for all modes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
fixes #8476