update to ionic 3.0.1 #95

peterennis · 2017-04-17T02:48:49Z

Ionic View App Id 831ef985

I do not see where the maps and some other features are turned on
and I could not find the translation test form.

However this should help close the following:

#88
ionic v3 super template fail with ionic-native ionic-team/ionic-framework#11231
fix(ionic-native): update ionic native to 3.1.0 #84
Missing ionic-native #85
How do I test this template ? #87
Super template not compatible with ionic-native 3+ #86

C:\ae\ionic-starter-super>ionic info

Your system information:

 ordova CLI: 6.5.0
Ionic Framework Version: 3.0.1
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.3.0
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 10
Node Version: v6.10.2
Xcode version: Not installed

janpio

Went through it quickly and noticed some things.

janpio · 2017-04-17T03:11:23Z

src/app/app.module.ts


 // The translate loader needs to know where to load i18n files
 // in Ionic's static asset pipeline.
 export function createTranslateLoader(http: Http) {
-  return new TranslateStaticLoader(http, './assets/i18n', '.json');
+  return new TranslateHttpLoader(http, './assets/i18n', '.json');


This doesn't look right, change from Static to Http?

I do not know the internal details. Please feel free to correct as appropriate.

From here: https://github.com/ngx-translate/core

Configuration

By default, there is no loader available. You can add translations manually using setTranslation but it is better to use a loader. You can write your own loader, or import an existing one. For example you can use the TranslateHttpLoader that will load translations from files using Http.

Once you've decided which loader to use, you have to setup the TranslateModule to use it.

Here is how you would use the TranslateHttpLoader to load translations from "/assets/i18n/[lang].json" ([lang] is the lang that you're using, for english it could be en):

You are correct:

replace the TranslateStaticLoader ()if you use it) with the TranslateHttpLoader

https://github.com/ngx-translate/core/blob/master/MIGRATION_GUIDE.md#migration-guide-from-ng2-translate-5-to-ngx-translate-6

I did a search and there is no reference to TranslateStaticLoader on the ngx-translate page.
There are some references to "static".
This could be a result of the 5.0.0 to 6.0.1 transition with Angular 4.0.0 but I have not looked into it in depth. You could follow up with the author if needed.

AoT

If you want to configure a custom TranslateLoader while using AoT compilation or Ionic 2, you must use an exported function instead of an inline function.

export function createTranslateLoader(http: Http) { return new TranslateHttpLoader(http, './assets/i18n/', '.json'); }

I think that in line 41 you need to put an ending slash, this:
return new TranslateHttpLoader(http, './assets/i18n', '.json');
to this:
return new TranslateHttpLoader(http, './assets/i18n/', '.json');

janpio · 2017-04-17T03:13:31Z

package.json

+    "ionic-plugin-keyboard"
+  ],
+  "cordovaPlatforms": [],
+  "description": "aesuper: An Ionic project"
 }


package.json in starters only contains the things that are different or additional to the app base that it is combined with: https://github.com/driftyco/ionic2-app-base/blob/master/package.json. You should probably get rid of all this and only keep the translate stuff.

OK. Looks like a leftover artifact from my clone process i.e. pre-fork. I will run a compare with the original and fix it.

janpio · 2017-04-17T03:14:38Z

src/pages/item-create/item-create.ts

@@ -41,18 +41,15 @@ export class ItemCreatePage {
  }

  getPicture() {
-    if (Camera['installed']()) {


this check got lost in the new code

janpio · 2017-04-17T03:15:49Z

src/pages/map/map.ts

-    GoogleMap.isAvailable().then(() => {
-      const position = new GoogleMapsLatLng(43.074395, -89.381056);
-      this.map.setPosition(position);
+    this.googleMaps.isAvailable().then(() => {


Typo? this.googleMaps => this.googleMap

Likely. I will make the change. However, I did not see maps in the app. There may still be config issues or operator error.

Looks like not a typo, or there is something wrong with the typescript intellisense. I will leave it as is and someone with more knowledge should check.

peterennis · 2017-04-18T20:55:45Z

There now 4 PR's related to this.
#84, #90, #95, #96
@maxlynch, Here is a request by ionic to test this app:
http://blog.ionic.io/help-us-test-the-super-starter/

It seems to me that the community has responded but ionic is asleep at the wheel.
I would appreciate some input on when this issue will be laid to rest.

ccerrillo · 2017-05-09T06:33:51Z

src/app/app.module.ts


 // The translate loader needs to know where to load i18n files
 // in Ionic's static asset pipeline.
 export function createTranslateLoader(http: Http) {
-  return new TranslateStaticLoader(http, './assets/i18n', '.json');
+  return new TranslateHttpLoader(http, './assets/i18n', '.json');


I think that in line 41 you need to put an ending slash, this:
return new TranslateHttpLoader(http, './assets/i18n', '.json');
to this:
return new TranslateHttpLoader(http, './assets/i18n/', '.json');

danielsogl · 2017-05-11T19:41:38Z

Thank you @peterennis for all your suggestions. Becuase your PR it to large, and it is not possible to split it into smaller commits, I have to close your PR but I implemented your suggestions.

Thank you for your help!

update to ionic 3.0.1

5afad48

This was referenced Apr 17, 2017

ionic 3 starter super master error ionic-team/ionic-framework#11236

Closed

ionic v3 super template fail with ionic-native ionic-team/ionic-framework#11231

Closed

janpio suggested changes Apr 17, 2017

View reviewed changes

fixes for #95 (comment)

4358acc

This was referenced Apr 19, 2017

ngx-translate json file has new format #98

Closed

__webpack_require is not a function in upgrade to v3.0.1 ionic-team/ionic-app-scripts#891

Closed

edmundo096 mentioned this pull request Apr 25, 2017

Cannot find module "ionic-native" #99

Closed

timofeysie mentioned this pull request Apr 30, 2017

Can't resolve all parameters for Storage: (?) #102

Closed

ccerrillo suggested changes May 9, 2017

View reviewed changes

danielsogl closed this May 11, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update to ionic 3.0.1 #95

update to ionic 3.0.1 #95

peterennis commented Apr 17, 2017

janpio left a comment

janpio Apr 17, 2017

peterennis Apr 17, 2017

janpio Apr 17, 2017

peterennis Apr 17, 2017

ccerrillo May 9, 2017

janpio Apr 17, 2017

peterennis Apr 17, 2017

janpio Apr 17, 2017

peterennis Apr 17, 2017

janpio Apr 17, 2017

peterennis Apr 17, 2017

peterennis Apr 18, 2017

peterennis commented Apr 18, 2017

ccerrillo May 9, 2017

danielsogl commented May 11, 2017

update to ionic 3.0.1 #95

update to ionic 3.0.1 #95

Conversation

peterennis commented Apr 17, 2017

janpio left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peterennis commented Apr 18, 2017

Choose a reason for hiding this comment

danielsogl commented May 11, 2017