fix(menu): crash when menu if forcedClosed

ionic-team · Sep 25, 2018 · 22e15b4 · 22e15b4
1 parent b71b36c
commit 22e15b4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/core/src/components/menu/menu.tsx b/core/src/components/menu/menu.tsx
@@ -392,7 +392,8 @@ export class Menu implements ComponentInterface, MenuI {
     this.lastOnEnd = detail.timeStamp;
     this.animation
       .onFinish(() => this.afterAnimation(shouldOpen), {
-        clearExistingCallbacks: true
+        clearExistingCallbacks: true,
+        oneTimeCallback: true
       })
       .progressEnd(shouldComplete, stepValue, realDur);
   }

diff --git a/core/src/components/menu/test/basic/index.html b/core/src/components/menu/test/basic/index.html
@@ -31,7 +31,7 @@
 
       <ion-content>
         <ion-list>
-          <ion-item>Open end Menu</ion-item>
+          <ion-item button onclick="openEnd()">Open end Menu</ion-item>
           <ion-item>Close Menu</ion-item>
           <ion-item>Close Menu</ion-item>
           <ion-item>Close Menu</ion-item>
@@ -108,6 +108,7 @@
       menu.open('start');
     }
     function openEnd() {
+      debugger;
       console.log('Open end menu');
       menu.open('end');
     }