Skip to content

Commit

Permalink
fix(schematics): update ngAdd schematic (#22858)
Browse files Browse the repository at this point in the history
* fix(schematics): update ngAdd schematic
Closes ionic-team/angular-toolkit#415
Closes ionic-team/angular-toolkit#419

* Update angular/src/schematics/utils/config.ts

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>

* Update angular/src/schematics/add/index.ts

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
  • Loading branch information
mhartington and liamdebeasi committed Feb 2, 2021
1 parent b6b2d34 commit 487349f
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 6 deletions.
12 changes: 8 additions & 4 deletions angular/src/schematics/add/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,20 +40,23 @@ function addIonicAngularModuleToAppModule(projectSourceRoot: Path): Rule {
function addIonicStyles(projectName: string, projectSourceRoot: Path): Rule {
return (host: Tree) => {
const ionicStyles = [
'node_modules/@ionic/angular/css/core.css',
'node_modules/@ionic/angular/css/normalize.css',
'node_modules/@ionic/angular/css/structure.css',
'node_modules/@ionic/angular/css/typography.css',
'node_modules/@ionic/angular/css/core.css',
'node_modules/@ionic/angular/css/display.css',
'node_modules/@ionic/angular/css/padding.css',
'node_modules/@ionic/angular/css/float-elements.css',
'node_modules/@ionic/angular/css/text-alignment.css',
'node_modules/@ionic/angular/css/text-transformation.css',
'node_modules/@ionic/angular/css/flex-utils.css',
`${projectSourceRoot}/theme/variables.css`
].forEach(entry => {
]

ionicStyles.forEach(entry => {
addStyle(host, projectName, entry);
});
return host;
return host;
};
}

Expand All @@ -64,7 +67,8 @@ function addIonicons(projectName: string): Rule {
input: 'node_modules/ionicons/dist/ionicons/svg',
output: './svg'
};
addAsset(host, projectName, ioniconsGlob);
addAsset(host, projectName, 'build', ioniconsGlob);
addAsset(host, projectName, 'test', ioniconsGlob);
return host;
};
}
Expand Down
4 changes: 2 additions & 2 deletions angular/src/schematics/utils/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,10 @@ export function addStyle(host: Tree, projectName: string, stylePath: string) {
writeConfig(host, config);
}

export function addAsset(host: Tree, projectName: string, asset: string | {glob: string; input: string; output: string}) {
export function addAsset(host: Tree, projectName: string, architect: string, asset: string | {glob: string; input: string; output: string}) {
const config = readConfig(host);
const appConfig = getAngularAppConfig(config, projectName);
appConfig.architect.build.options.assets.push(asset);
appConfig.architect[architect].options.assets.push(asset);
writeConfig(host, config);
}

Expand Down

0 comments on commit 487349f

Please sign in to comment.