fix(slides): fix mutable options

ionic-team · Sep 15, 2018 · 681981f · 681981f
1 parent 7bc9a07
commit 681981f
Show file tree

Hide file tree

Showing 7 changed files with 241 additions and 48 deletions.
diff --git a/core/package.json b/core/package.json
@@ -46,7 +46,7 @@
     "selenium-webdriver": "^3.6.0",
     "stylelint": "^9.4.0",
     "stylelint-order": "^0.8.1",
-    "swiper": "4.3.5",
+    "swiper": "4.4.1",
     "tslint": "^5.10.0",
     "tslint-ionic-rules": "0.0.19",
     "tslint-react": "^3.6.0",

diff --git a/core/src/components.d.ts b/core/src/components.d.ts
@@ -4223,7 +4223,7 @@ export namespace Components {
     /**
     * Transition to the next slide.
     */
-    'slideNext': (speed: number, runCallbacks: boolean) => Promise<void>;
+    'slideNext': (speed?: number | undefined, runCallbacks?: boolean | undefined) => Promise<void>;
     /**
     * Transition to the previous slide.
     */

diff --git a/core/src/components/datetime/datetime.tsx b/core/src/components/datetime/datetime.tsx
@@ -233,9 +233,9 @@ export class Datetime implements ComponentInterface {
     }
 
     const pickerOptions = this.generatePickerOptions();
-    this.picker = await this.pickerCtrl.create(pickerOptions);
+    const picker = this.picker = await this.pickerCtrl.create(pickerOptions);
     await this.validate();
-    await this.picker.present();
+    await picker.present();
   }
 
   private emitStyle() {

diff --git a/core/src/components/slides/slides.tsx b/core/src/components/slides/slides.tsx
@@ -38,10 +38,12 @@ export class Slides implements ComponentInterface {
   @Prop() options: any = {}; // SwiperOptions;  // TODO
 
   @Watch('options')
-  async updateSwiperOptions() {
-    const swiper = await this.getSwiper();
-    swiper.params = this.normalizeOptions();
-    await this.update();
+  async optionsChanged() {
+    if (this.didInit) {
+      const swiper = await this.getSwiper();
+      Object.assign(swiper.params, this.options);
+      await this.update();
+    }
   }
 
   /**
@@ -173,9 +175,9 @@ export class Slides implements ComponentInterface {
    * Transition to the next slide.
    */
   @Method()
-  async slideNext(speed: number, runCallbacks: boolean) {
+  async slideNext(speed?: number, runCallbacks?: boolean) {
     const swiper = await this.getSwiper();
-    swiper.slideNext(speed, runCallbacks);
+    swiper.slideNext(speed!, runCallbacks!);
   }
 
   /**