fix(icon): target element for style and add to breaking

ionic-team · Jun 26, 2018 · 949d93e · 949d93e
1 parent e629e29
commit 949d93e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/angular/BREAKING.md b/angular/BREAKING.md
@@ -463,11 +463,14 @@ If any `CSS` is being overridden for an icon it will need to change to override
 **New Usage Example:**
 
 ```css
-.icon {
+ion-icon {
   fill: #000;
 }
 ```
 
+_Note: we are no longer adding the `icon` class to an `ion-icon`, so the element should be targeted instead._
+
+
 ### Property Removed
 
 The `isActive` property has been removed. It only worked for `ios` icons previously. If you would like to switch between an outline and solid icon you should set it in the `name`, or `ios`/`md` attribute and then change it when needed.

diff --git a/core/src/components/icon/test/standalone/index.html b/core/src/components/icon/test/standalone/index.html
@@ -55,7 +55,7 @@
   <ion-icon name="rainy" color="primary"></ion-icon>
 
   <style>
-    .icon {
+    ion-icon {
       font-size: 50px;
       margin: 9px;
     }