Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ion-list lines="none" not working on ios #14769

Closed
Rift-Walker opened this issue Jul 13, 2018 · 1 comment
Closed

ion-list lines="none" not working on ios #14769

Rift-Walker opened this issue Jul 13, 2018 · 1 comment
Labels

Comments

@Rift-Walker
Copy link
Contributor

Bug Report

Ionic Info

Ionic:

   ionic (Ionic CLI)          : 4.0.0-rc.10 (/Users/nathanwalker/.nvm/versions/node/v8.11.3/lib/node_modules/ionic)
   Ionic Framework            : @ionic/angular 4.0.0-alpha.10
   @angular-devkit/core       : 0.7.0-rc.1
   @angular-devkit/schematics : 0.7.0-rc.1
   @angular/cli               : 6.0.8
   @ionic/ng-toolkit          : 1.0.0-rc.9
   @ionic/schematics-angular  : 1.0.0-rc.9

Cordova:

   cordova (Cordova CLI) : 8.0.0
   Cordova Platforms     : android 7.0.0 ios 4.5.4

System:

   ios-deploy : 1.9.2
   NodeJS     : v8.11.3 (/Users/nathanwalker/.nvm/versions/node/v8.11.3/bin/node)
   npm        : 5.6.0
   OS         : macOS High Sierra
   Xcode      : Xcode 9.4.1 Build version 9F2000

Environment:

   ANDROID_HOME : not set

Describe the Bug
ion-list with lines="none" still has lines in ios mode.

Steps to Reproduce
Steps to reproduce the behavior:

  1. Instantiate an ion-list with lines="none"
  2. ionic serve --platform=ios
  3. See lines under list items

Related Code
https://plnkr.co/edit/2l5i8L4bDOeAf03nIiQ9?p=preview

Expected Behavior
A list with lines="none" should have no lines.

Additional Context
The problem is here:
https://github.com/ionic-team/ionic/blob/ea7d09b41ebaa171d46fc370cfe593f813403a64/core/src/components/list/list.ios.scss#L11-L14
I don't know what the purpose of this line is, but we could change it to something like this:
.list-ios:not(.list-inset):not(.list-ios-lines-none) .item:last-child {

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 1, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant