Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ion-select not selecting falsy values #15420

Closed
comfortme opened this issue Aug 31, 2018 · 4 comments
Closed

ion-select not selecting falsy values #15420

comfortme opened this issue Aug 31, 2018 · 4 comments
Assignees

Comments

@comfortme
Copy link

Bug Report

Describe the Bug
ion-select is not selecting if value is 0 or false

Steps to Reproduce
Steps to reproduce the behavior:
1.select 1 first.
2.see it is selected normally
3.select 0 and see its not selected.
4.change 0 to false and see its not selected also.

Related Code
https://stackblitz.com/edit/github-igwscn

Expected Behavior
select should select falsy values.

@ionitron-bot ionitron-bot bot added the triage label Aug 31, 2018
@ionitron-bot ionitron-bot bot removed the triage label Sep 13, 2018
@brandyscarney
Copy link
Member

Note to team: I was able to reproduce this in the core branch using latest. If you add a log in the @Watch function of the value you will see the value is where it should be 0. To reproduce this go to select/test/basic and look at the Numbers example here: https://github.com/ionic-team/ionic/blob/master/core/src/components/select/test/basic/index.html#L210-L220

I believe this may be an issue with Stencil but it needs more digging. cc @manucorporat

@brandyscarney
Copy link
Member

brandyscarney commented Sep 19, 2018

Found the source of the issue. This is actually a problem with the way we set the value in the Alert. Working on a fix.

@brandyscarney brandyscarney self-assigned this Sep 19, 2018
@brandyscarney
Copy link
Member

This will be fixed for select using the alert interface in the 4.0.0-beta.12 release. I confirmed it is also working using the popover or action-sheet interface.

Thank you for the issue!

@ionitron-bot
Copy link

ionitron-bot bot commented Oct 19, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Oct 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants