Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segment as Tabs #16232

Closed
brandyscarney opened this issue Nov 5, 2018 · 1 comment
Closed

Segment as Tabs #16232

brandyscarney opened this issue Nov 5, 2018 · 1 comment

Comments

@brandyscarney
Copy link
Member

Segment needs to be updated to match the Material Design tabs spec: https://material-components.github.io/material-components-web-catalog/#/component/tabs
@ionitron-bot ionitron-bot bot added triage and removed triage labels Nov 5, 2018
brandyscarney added a commit that referenced this issue Nov 8, 2018
@brandyscarney
fix(segment): add layout and update design
144b436 
- moves the segment button css back into segment-button
- updates the design to match the MD spec better
- includes layout property to match MD spec
- adds custom properties
- allows for overscroll
- changes the indicator to a div for future

references #16232
This was referenced Nov 8, 2018
Merged
Closed
@brandyscarney brandyscarney mentioned this issue Nov 20, 2018
Closed
@ionitron-bot
Copy link

ionitron-bot bot commented Dec 15, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Dec 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brandyscarney