New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4-beta.15] Toast middle = top #16271

Closed
peterpeterparker opened this Issue Nov 8, 2018 · 1 comment

Comments

Projects
2 participants
@peterpeterparker
Contributor

peterpeterparker commented Nov 8, 2018

Bug Report

Ionic Info

Ionic v4-beta.15

Describe the Bug
It looks like the toast "middle" is actually displayed at the top.

Steps to Reproduce

  1. Go to documentation https://beta.ionicframework.com/docs/api/toast
  2. Click on 'Show toast middle'

P.S.: I observe the same behavior with my app

Expected Behavior
Toast middle = middle of the screen

Additional Context
Not sure but it might happens since beta.15 only

@ionitron-bot ionitron-bot bot added the triage label Nov 8, 2018

@peterpeterparker peterpeterparker changed the title from Toast middle = top to [v4-beta.15] Toast middle = top Nov 8, 2018

@brandyscarney brandyscarney added this to Backlog 🤖 in Core via automation Nov 8, 2018

@ionitron-bot ionitron-bot bot removed the triage label Nov 8, 2018

@brandyscarney

This comment has been minimized.

Member

brandyscarney commented Nov 9, 2018

Thank you for the issue! I am able to reproduce this.

Note to team: I had to downgrade to beta.11 in order to see toast working properly. The style for top is not being applied from here:

const topPosition = Math.floor(
  baseEl.clientHeight / 2 - wrapperEle.clientHeight / 2
);
wrapperEle.style.top = `${topPosition}px`;
wrapperAnimation.fromTo('opacity', 0.01, 1);

This is because baseEl is being read in as a shadow root. cc @manucorporat

@brandyscarney brandyscarney moved this from Backlog 🤖 to Needs review 🤔 in Core Nov 14, 2018

Core automation moved this from Needs review 🤔 to Done 🎉 Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment