Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: change tab / toolbar defaults to white for both ios and md #16384

Closed
brandyscarney opened this issue Nov 19, 2018 · 1 comment · Fixed by #16454
Closed

Enhancement: change tab / toolbar defaults to white for both ios and md #16384

brandyscarney opened this issue Nov 19, 2018 · 1 comment · Fixed by #16454

Comments

@brandyscarney
Copy link
Member

We need to update the background of the toolbar & tabbar to white by default per @bensperry
@ionitron-bot ionitron-bot bot added triage and removed triage labels Nov 19, 2018
@brandyscarney brandyscarney changed the title Enhancement: change MD tab / toolbar defaults to white Enhancement: change tab / toolbar defaults to white for both ios and md Nov 26, 2018
brandyscarney added a commit that referenced this issue Nov 26, 2018
@brandyscarney
fix(themes): update default toolbar and tab background to #fff
d41060f 
fixes #16384

BREAKING CHANGES

The default background color for the Toolbar and Tab Bar is now white (#fff).

This can be changed by overriding the following CSS variables:

```
--ion-toolbar-background
--ion-tab-bar-background
--ion-tab-bar-background-focused
```

See https://beta.ionicframework.com/docs/theming/css-variables for more information.
@brandyscarney brandyscarney mentioned this issue Nov 26, 2018
Merged
brandyscarney added a commit that referenced this issue Nov 26, 2018
@brandyscarney
fix(themes): update default toolbar and tab background to #fff (#16454)
12bcb41 
fixes #16384

BREAKING CHANGES

The default background color for the Toolbar and Tab Bar is now white (#fff).

This can be changed by overriding the following CSS variables:

```
--ion-toolbar-background
--ion-tab-bar-background
--ion-tab-bar-background-focused
```

See https://beta.ionicframework.com/docs/theming/css-variables for more information.
@ionitron-bot
Copy link

ionitron-bot bot commented Dec 26, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Dec 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(themes): update default toolbar and tab background to #fff ionic-team/ionic-framework
1 participant
@brandyscarney