Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button): Contain strict to contain content #16553

Merged
merged 1 commit into from Dec 2, 2018
Merged

fix(button): Contain strict to contain content #16553

merged 1 commit into from Dec 2, 2018

Conversation

paulstelzer
Copy link
Contributor

@paulstelzer paulstelzer commented Dec 2, 2018 •
edited

Short description of what this resolves:

Fixes a problem with contain: strict on ion-button on expand full and block.

I think that contain: content; should work on all other use cases like contain: strict, but the screenshot tests will show us :)

Fixes: #16552

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Dec 2, 2018
@manucorporat manucorporat merged commit 802a3d1 into ionic-team:master Dec 2, 2018
@manucorporat
Copy link
Contributor

@paulstelzer thanks a lot for the good PR! as usual!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paulstelzer @manucorporat