Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improved Desktop Support] MouseOver (Hover) Effect #17624

Closed
heinzburgstaller opened this issue Feb 26, 2019 · 2 comments
Closed

[Improved Desktop Support] MouseOver (Hover) Effect #17624

heinzburgstaller opened this issue Feb 26, 2019 · 2 comments
Assignees
@brandyscarney
Labels
package: core @ionic/core package type: feature request a new feature, enhancement, or improvement
Milestone
Ionic for Desktop

Comments

@heinzburgstaller
Copy link

Feature Request

Ionic version:

[x] 4.x

Describe the Feature Request
Ionic components (ion-button, ion-item, etc.) do not have a (ripple) effect when the mouse cursor hovers over the component. A desktop app is more user friendly if the user has a visual clue which components are interactable.

Describe Preferred Solution
Ionic simple adds those effects to existing components, or has a configuration property to enable hover effects globally.

Describe Alternatives
Provide directives/CSS classes to help implement effects on behalf of a third party developer.
@ionitron-bot ionitron-bot bot added the triage label Feb 26, 2019
@liamdebeasi liamdebeasi added the type: feature request a new feature, enhancement, or improvement label Feb 27, 2019
@ionitron-bot ionitron-bot bot removed the triage label Feb 27, 2019
@brandyscarney brandyscarney added this to the Ionic for Desktop milestone Apr 4, 2019
@brandyscarney brandyscarney added the package: core @ionic/core package label Jun 5, 2019
@brandyscarney brandyscarney mentioned this issue Jun 5, 2019
Merged
13 tasks
brandyscarney added a commit that referenced this issue Jun 10, 2019
@brandyscarney
feat(back-button): add variables and support for focused and hover st…
58672fb 
…ates (#18451)

- updates MD spacing for back button text
- also adds e2e tests and adds them to screenshot

references #18279 references #17624 fixes #18465
brandyscarney added a commit that referenced this issue Jun 10, 2019
@brandyscarney
fix(button): use correct border-radius on menu & back button
039a633 
- adds hover and focused state to menu button

references #17624
@brandyscarney brandyscarney mentioned this issue Jun 10, 2019
Merged
13 tasks
brandyscarney added a commit that referenced this issue Jun 10, 2019
@brandyscarney
fix(button): use correct border-radius on menu & back button (#18501)
055e125 
- adds hover and focused state to menu button

references #17624
abennouna pushed a commit to abennouna/ionic that referenced this issue Jun 11, 2019
@brandyscarney @abennouna
feat(back-button): add variables and support for focused and hover st…
d019c8c 
…ates (ionic-team#18451)

- updates MD spacing for back button text
- also adds e2e tests and adds them to screenshot

references ionic-team#18279 references ionic-team#17624 fixes ionic-team#18465
abennouna pushed a commit to abennouna/ionic that referenced this issue Jun 11, 2019
@brandyscarney @abennouna
fix(button): use correct border-radius on menu & back button (ionic-t…
c2c1bfa 
…eam#18501)

- adds hover and focused state to menu button

references ionic-team#17624
@brandyscarney brandyscarney self-assigned this Jun 13, 2019
brandyscarney added a commit that referenced this issue Jun 13, 2019
@brandyscarney
fix(fab-button): add hover state using tint colors
f4fd524 
references #17624
@brandyscarney brandyscarney mentioned this issue Jun 13, 2019
Merged
13 tasks
brandyscarney added a commit that referenced this issue Jun 25, 2019
@brandyscarney
feat(item): add focused and hover variables
8b0fa29 
references #18279 references #17624
brandyscarney added a commit that referenced this issue Jun 25, 2019
@brandyscarney
feat(fab-button): add hover state using tint colors (#18536)
ad00679 
- fixes a bug where backdrop filter was not applied on translucent buttons and checks for support first

references #17624
brandyscarney added a commit that referenced this issue Jun 25, 2019
@brandyscarney
feat(item): add hover and focused states (#18606)
8a88dd2 
references #18279 references #17624
@brandyscarney
Copy link
Member

Thank you for the issue! I'm going to close this in favor of #18279. I am tracking all of the components needing updates there. This PR will also make some big changes to hover, focused and activated: #19440

@ionitron-bot
Copy link

ionitron-bot bot commented Feb 16, 2020

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brandyscarney brandyscarney

Labels
package: core @ionic/core package type: feature request a new feature, enhancement, or improvement
Projects
None yet
Milestone
Ionic for Desktop
Development

No branches or pull requests
3 participants
@liamdebeasi @brandyscarney @heinzburgstaller