Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ticks attribute to range #17717

Closed
sethlilly opened this issue Mar 7, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@sethlilly
Copy link
Contributor

commented Mar 7, 2019

Feature Request

Ionic version:

  • 4.x

Describe the Feature Request

When using ion-range with snaps set to true, ticks are displayed; however, when using the snaps attribute the display of ticks may not always be desired.

Describe Preferred Solution

Add a ticks attribute (default: true) to ion-range to show/hide ticks when snaps is set to true.

Describe Alternatives

Because this is styled in shadow DOM, there really isn't a good way to override the display of these elements from outside the component aside from setting a CSS variable but that only results in hiding the ticks. The solution above prevents the ticks from being rendered in the first place, resulting in a cleaner DOM.

Related Code

...

Additional Context

PR forthcoming.

@d0x

This comment has been minimized.

Copy link

commented Mar 11, 2019

Nice Idea with the Ticks Attribute! The scss variables to disable the ticks which @sethlilly mentioned are:

        --bar-background: transparent;
        --bar-background-active: transparent;
        --ion-color-step-250: transparent;

(at least for ionic 4.0.2. Before that it was --ion-background-color-step-250: transparent instead of --ion-color-step-250)

@ionitron-bot

This comment has been minimized.

Copy link

commented Apr 25, 2019

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Apr 25, 2019

Kiku-git added a commit to Kiku-git/ionic that referenced this issue May 16, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.