-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(range): add ticks attribute #17718
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Added a minor request to update the documentation. The code itself looks great at first glance. 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 🎉
Added documentation change from @brandyscarney to match `if true` convention Co-Authored-By: sethlilly <seth.lilly@gmail.com>
Thanks, @brandyscarney and @liamdebeasi! |
Short description of what this resolves:
When using
range
withsnaps
set totrue
, ticks are displayed; however, when using thesnaps
attribute the display of ticks may not always be desired. This PR adds aticks
attribute torange
.Changes proposed in this pull request:
ticks
attribute torange
Ionic Version:
Fixes: #17717