Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(range): add ticks attribute #17718

Merged
merged 10 commits into from
Mar 26, 2019
Merged

feat(range): add ticks attribute #17718

merged 10 commits into from
Mar 26, 2019

Conversation

sethlilly
Copy link
Contributor

Short description of what this resolves:

When using range with snaps set to true, ticks are displayed; however, when using the snaps attribute the display of ticks may not always be desired. This PR adds a ticks attribute to range.

Changes proposed in this pull request:

  • Add ticks attribute to range

Ionic Version:

  • 4.x

Fixes: #17717

@ionitron-bot ionitron-bot bot added package: angular @ionic/angular package package: core @ionic/core package labels Mar 7, 2019
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Added a minor request to update the documentation. The code itself looks great at first glance. 🎉

core/src/components/range/range.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🎉

brandyscarney and others added 3 commits March 26, 2019 13:42
Added documentation change from @brandyscarney to match `if true` convention

Co-Authored-By: sethlilly <seth.lilly@gmail.com>
@sethlilly
Copy link
Contributor Author

Thanks, @brandyscarney and @liamdebeasi!

@brandyscarney brandyscarney merged commit 016fa16 into ionic-team:master Mar 26, 2019
kiku-jw pushed a commit to kiku-jw/ionic that referenced this pull request May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants