Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): use correct border-radius on menu & back button #18501

Merged
merged 2 commits into from
Jun 10, 2019

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Jun 10, 2019

  • adds hover and focused state to iOS menu button

references #17624

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

- adds hover and focused state to menu button

references #17624
@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Jun 10, 2019
@brandyscarney brandyscarney merged commit 055e125 into master Jun 10, 2019
@brandyscarney brandyscarney deleted the fix-menu-button branch June 10, 2019 21:58
abennouna pushed a commit to abennouna/ionic that referenced this pull request Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant