Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs): apply ng form classes #18820

Merged
merged 1 commit into from
Jul 17, 2019
Merged

fix(inputs): apply ng form classes #18820

merged 1 commit into from
Jul 17, 2019

Conversation

manucorporat
Copy link
Contributor

@manucorporat manucorporat commented Jul 17, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

Fixes #18800

@ionitron-bot ionitron-bot bot added the package: angular @ionic/angular package label Jul 17, 2019
@manucorporat manucorporat merged commit 53179c4 into master Jul 17, 2019
@manucorporat manucorporat deleted the fix-inputs-classes branch August 28, 2019 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(ionic-angular): ion-valid and other form state classes are not copied to the parent ion-item
1 participant