-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(refresher): iOS native refresher #20037
Conversation
…en still pulling or collapsing in single gesture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: discuss the API surrounding the contentId
Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>
Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>
Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>
Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>
Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>
Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>
Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>
Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few notes on using this:
- The iOS refresher doesn't work on desktop, should fallback to the non-native refresher
- These should be the defaults for
ios
:pulling-icon="lines" refreshing-spinner="lines"
- Look into alternatives to wrapping the content with a div containing
contentId
Ok iOS refresher now falls back to the non-native refresher on desktop. I tried playing with the native refresher on desktop Safari, but the experience just didn't really feel too great. Even the "native" refresher in News on macOS doesn't really feel smooth.
Still not sure about how we can get around adding the |
@liamdebeasi Maybe we just document that Safari / browsers on desktop running iOS mode won't use the native refresher & therefore will look "off". If they want it to look nice on both they need to do platform detection to change the value? |
Yeah a bunch of usage examples would probably be good here for that. I think running in iOS mode on desktop is a valid use case, so it would be ideal if it looked correct out of the box. Maybe we can have the refresher icon default to the old icon only on desktop iOS mode? Not sure if that makes things easier or more confusing to work with. |
…esher, update docs
Dev build:
5.0.0-dev.201912061730.b8359e0
needs review: the
contentId
prop. This was added so we can translate the content to not bounce back over the refresher without interfering with the user's styling (if we translated the inner scroll, users would see a white space where the content once was).Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #18664
What is the new behavior?
Does this introduce a breaking change?
Other information