Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Ionic 5 button state issues #20276

Closed
brandyscarney opened this issue Jan 23, 2020 · 1 comment · Fixed by #20278
Closed

bug: Ionic 5 button state issues #20276

brandyscarney opened this issue Jan 23, 2020 · 1 comment · Fixed by #20278
Assignees
@brandyscarney
Labels
package: core @ionic/core package

Comments

@brandyscarney
Copy link
Member

brandyscarney commented Jan 23, 2020 •
edited
Loading

Known mismatches caused by this PR: #19440

Screen Shot 2020-01-23 at 4 47 20 PM

Screen Shot 2020-01-23 at 4 50 17 PM

Screen Shot 2020-01-23 at 4 47 08 PM

Screen Shot 2020-01-23 at 4 47 15 PM

Screen Shot 2020-01-23 at 4 48 55 PM

Screen Shot 2020-01-23 at 4 50 31 PM
@ionitron-bot ionitron-bot bot added the triage label Jan 23, 2020
@brandyscarney brandyscarney self-assigned this Jan 23, 2020
@brandyscarney brandyscarney added the package: core @ionic/core package label Jan 23, 2020
@ionitron-bot ionitron-bot bot removed the triage label Jan 23, 2020
This was referenced Jan 23, 2020
Merged
Closed
brandyscarney added a commit that referenced this issue Jan 27, 2020
@brandyscarney
fix(components): fix issues with button states (#20278)
628db18 
- Update action sheet colors to match spec (md)
- Remove activated background on buttons (md - uses ripple)
- Update Segment Button to use proper indicator color when inside of a toolbar
- Add back input highlight on focus

fixes #20276
@ionitron-bot
Copy link

ionitron-bot bot commented Feb 26, 2020

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Feb 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brandyscarney brandyscarney

Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(components): fix issues with button states ionic-team/ionic-framework
1 participant
@brandyscarney