Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: iOS Swipable Modal causing Android to shrink statusbar #20569

Closed
Yohandah opened this issue Feb 20, 2020 · 6 comments
Closed

bug: iOS Swipable Modal causing Android to shrink statusbar #20569

Yohandah opened this issue Feb 20, 2020 · 6 comments
Labels
package: core @ionic/core package type: bug a confirmed bug report
Milestone

Comments

@Yohandah
Copy link

Yohandah commented Feb 20, 2020

Bug Report

Ionic version:
[x] 5.x

Current behavior:
When enabling swipeToClose + presenting element on a modal, Android toolbar is shrinked into the statusbar.

Expected behavior:
It should be as when presentingElement isn't set.

Steps to reproduce:

  • Configure a modal :
  async showEditModal(): Promise<void> {
    const modal: HTMLIonModalElement = await this._modalController.create({
      component: EditHomeModalComponent,
      swipeToClose: true,
      presentingElement: this.routerOutlet.nativeEl
    });

    await modal.present();
  }
  • Open the modal on Android => The toolbar is in the statusbar
  • Remove presentingElement property
  • Open the modal on Android => The toolbar is fine

Other information:
With presentingElement
swipable

Without presentingElement
not_swipable

Ionic info:

Ionic:

   Ionic CLI                     : 6.0.2 (C:\Users\YD7A0C5N\AppData\Roaming\npm\node_modules\@ionic\cli)
   Ionic Framework               : @ionic/angular 5.0.1
   @angular-devkit/build-angular : 0.900.3
   @angular-devkit/schematics    : 9.0.3
   @angular/cli                  : 9.0.3
   @ionic/angular-toolkit        : 2.1.2

Capacitor:

   Capacitor CLI   : 1.4.0
   @capacitor/core : 1.4.0

Utility:

   cordova-res : not installed
   native-run  : not installed

System:

   NodeJS : v12.13.1 (C:\Program Files\nodejs\node.exe)
   npm    : 6.12.1
   OS     : Windows 10

@ionitron-bot ionitron-bot bot added the triage label Feb 20, 2020
@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report labels Feb 20, 2020
@liamdebeasi liamdebeasi added this to the 5.0.2 milestone Feb 20, 2020
@ionitron-bot ionitron-bot bot removed the triage label Feb 20, 2020
@liamdebeasi
Copy link
Contributor

Thanks for the issue. Can you try the following dev build and let me know if it resolves the issue?

npm i @ionic/angular@5.1.0-dev.202002201722.65941af

@Yohandah
Copy link
Author

@liamdebeasi When I do yarn add @ionic/angular@5.1.0-dev.202002201722.65941af it doesn't find it and ask me for this ?
image

@liamdebeasi
Copy link
Contributor

Try this dev build: 5.1.0-dev.202002211438.65941af

@Yohandah
Copy link
Author

@liamdebeasi It's all good, resolved 👍

Thanks

@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #20571 and will be available in an upcoming release of Ionic Framework.

@ionitron-bot
Copy link

ionitron-bot bot commented Mar 25, 2020

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Mar 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

2 participants