Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): scroll assist now works properly #20742

Merged
merged 3 commits into from
Mar 16, 2020
Merged

fix(): scroll assist now works properly #20742

merged 3 commits into from
Mar 16, 2020

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Mar 10, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #19589

At some point, scroll assist broke. I do not know if it was due to Ionic, an upgrade to Cordova/Capacitor, or an upgrade to iOS. The problem that exists now is that scroll assist is trying to scroll the input into view before the browser has rendered any scroll height updates. In other words, scroll assist tries to scroll to a point that is more than the currently rendered max scroll area.

This PR adds the callback to scroll into a resize event listener. This will cause the scroll to either wait for the resize event to happen or until the fallback timer fires after 1000ms -- whichever happens first.

What is the new behavior?

  • Listen for resize event before trying to scroll

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant