Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading icon of infinte-scroll not showing with collection-repeat #2376

Closed
matiastucci opened this issue Oct 10, 2014 · 24 comments
Closed

Loading icon of infinte-scroll not showing with collection-repeat #2376

matiastucci opened this issue Oct 10, 2014 · 24 comments
Assignees

Comments

@matiastucci
Copy link

Using ng-repeat (loading icon appears): http://codepen.io/anon/pen/CBtEg
Using collection-repeat (doesn't appear): http://codepen.io/matiastucci/pen/wkECs

Probably because of this?:

"You should not use the ng-show and ng-hide directives on your ion-content/ion-scroll elements that have a collection-repeat inside. ng-show and ng-hide apply the display: none css rule to the content's style, causing the scrollView to read the width and height of the content as 0. Resultingly, collection-repeat will render elements that have just been un-hidden incorrectly."

I know this is something small, but if you can fix it: great!

Thanks!

@bra1n
Copy link

bra1n commented Oct 17, 2014

👍 Ran into the same problem, seems like those 2 directives don't play along nicely.

@matiastucci
Copy link
Author

@bra1n I think is the ng-show of the collection-repeat

@naavis
Copy link

naavis commented Nov 14, 2014

I'm still experiencing this problem with beta-13.

@lanceli
Copy link

lanceli commented Dec 14, 2014

hotfix

var ionInfiniteScroll = self.element.find('ion-infinite-scroll');
if (ionInfiniteScroll.length === 1 && dataIndex !== 0) {
  ionInfiniteScroll.css(
    ionic.CSS.TRANSFORM,
    self.transformString(rect.primaryPos - self.beforeSize, rect.secondaryPos)
  );
}

add this before line 1071
https://github.com/driftyco/ionic/blob/v1.0.0-beta.13/release/js/ionic-angular.js

@sherlock221
Copy link

yeah @lanceli good job thankyou

@lanceli
Copy link

lanceli commented Feb 26, 2015

@perrygovier @ajoslin
Does not work in nightly 1081, reopen issue please.

@jryu01
Copy link

jryu01 commented Feb 27, 2015

I'm experiencing this problem with nightly build.

@ajoslin ajoslin reopened this Feb 28, 2015
@ajoslin
Copy link
Contributor

ajoslin commented Feb 28, 2015

I don't see a problem with http://codepen.io/anon/pen/CBtEg in the nightly builds. What's wrong?

@lanceli
Copy link

lanceli commented Feb 28, 2015

@ajoslin
Your codepen is ng-repeat, the issue with collection-repeat

@ajoslin ajoslin closed this as completed in af7a03c Mar 2, 2015
@ajoslin
Copy link
Contributor

ajoslin commented Mar 2, 2015

Fixed. Had to set the items after the collection repeat to display: block to make them always get the right size.

@luofan189
Copy link

It seems that this issue appears again in rc.5. The icon shows when using ng-repeat but not collection-repeat

@jamesgecko
Copy link

Yep. This worked in 1.0rc1 and is broken in 1.0.

@mvidailhet
Copy link

+1, broken for me in 1.0

@thpoul
Copy link

thpoul commented May 26, 2015

+1 for me

@hbmartin
Copy link

hbmartin commented Jun 1, 2015

Broken for me as well with ng-repeat 😿

@mica16
Copy link

mica16 commented Jun 11, 2015

Broken for me too with 1.0 ;)

@mpochron
Copy link

+1 reopen!

@SatadruBhattacharjee
Copy link

Broken for me with latest 1.0

@JWesorick
Copy link

+1!

@JWesorick
Copy link

@perrygovier @ajoslin Any update on when this may be fixed or a work around?

@degamer106
Copy link

BUMP

@jordansitbon
Copy link

UP! +1!

@swiftyone
Copy link

For me a simple workaround did the trick until it is fixed:

ion-infinite-scroll:not(.active) .spinner,
ion-infinite-scroll:not(.active) .icon:before {
    display: inline-block;
}

It is not mandatory that the icon is only visible if the ion-infinite-scroll-Element is active if you use a ng-show or ng-if directive:

<ion-infinite-scroll ng-show="showInfinite" icon="ion-load-c" on-infinite="loadData()">
</ion-infinite-scroll>

@shivarad
Copy link

ion-infinite scrolling is not working for me in v1.1.0 for vs2015 package of phongeap!

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests