Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set .active with ionicTouch #598

Closed
adamdbradley opened this issue Feb 13, 2014 · 3 comments
Closed

Set .active with ionicTouch #598

adamdbradley opened this issue Feb 13, 2014 · 3 comments
Assignees
Milestone

Comments

@adamdbradley
Copy link
Contributor

I just looked in the rendered ionic.css because I am having issue on Android devices: I don't have visual feedback when I press and hold a button down for exemple. In angular, I usually use the ng-click-active style for this as specified in the angular doc here:
http://docs.angularjs.org/api/ngTouch.directive:ngClick

But when I look in the rendered ionic.css file, I don't see this anywhere. For exemple, for button class, I found .button.active and .button:active classes, but no .button.ng-click-active class. I believe this is an issue if we are using ng-touch.

http://forum.ionicframework.com/t/ng-click-active-in-ionic-css/1063

@adamdbradley adamdbradley added this to the 0.9.25 milestone Feb 13, 2014
@adamdbradley adamdbradley self-assigned this Feb 13, 2014
@adamdbradley adamdbradley modified the milestones: 0.9.26, 0.9.25 Feb 18, 2014
@adamdbradley adamdbradley modified the milestones: 0.10.0, 0.9.26, 1.0 Beta2 Feb 26, 2014
@calendee
Copy link

@adamdbradley
Copy link
Contributor Author

As of 8c55e28 we're adding .active to list items and buttons when active. We do not recommend using ngTouch with Ionic because Ionic is already handling touch events.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants