Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(img): remove space under img #17582

Merged
merged 3 commits into from
Feb 25, 2019
Merged

fix(img): remove space under img #17582

merged 3 commits into from
Feb 25, 2019

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Feb 22, 2019 •
edited
Loading

Short description of what this resolves:

This isn't a bug per se, but rather the behavior of img that isn't really desirable. (https://stackoverflow.com/questions/5804256/image-inside-div-has-extra-space-below-the-image)

The result of this default behavior is to display the image inline, which causes a small gap to appear below the image. Instead, we have the img display block

Changes proposed in this pull request:

  • Add display: block to the img element

Ionic Version:

Fixes: #17543

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Feb 22, 2019
@liamdebeasi liamdebeasi merged commit 621c79b into master Feb 25, 2019
@liamdebeasi liamdebeasi deleted the fix-img-baseline branch February 25, 2019 14:28
@liamdebeasi liamdebeasi mentioned this pull request Feb 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamdebeasi @brandyscarney