Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(img): remove space under img #17582

Merged
merged 3 commits into from Feb 25, 2019

Conversation

Projects
None yet
2 participants
@liamdebeasi
Copy link
Member

commented Feb 22, 2019

Short description of what this resolves:

This isn't a bug per se, but rather the behavior of img that isn't really desirable. (https://stackoverflow.com/questions/5804256/image-inside-div-has-extra-space-below-the-image)

The result of this default behavior is to display the image inline, which causes a small gap to appear below the image. Instead, we have the img display block

Changes proposed in this pull request:

  • Add display: block to the img element

Ionic Version:

Fixes: #17543

@liamdebeasi liamdebeasi merged commit 621c79b into master Feb 25, 2019

2 checks passed

build Workflow: build
Details
screenshot Screenshot
Details

@liamdebeasi liamdebeasi deleted the fix-img-baseline branch Feb 25, 2019

KillerCodeMonkey added a commit to KillerCodeMonkey/ionic that referenced this pull request Mar 1, 2019

fix(img): remove space under img (ionic-team#17582)
* set align to bottom for image

* change to display block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.