Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toast): allow to change position start/end of toast #17961

Merged
merged 24 commits into from
Apr 16, 2019
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
594b75e
fix(toast): allow to change position left/right of toast
entom Apr 4, 2019
df4ade2
Updated api.txt and readme files
entom Apr 4, 2019
e420b79
Merge branch 'master' into full-width-toast
liamdebeasi Apr 5, 2019
305384d
Created test for toast with left/right position
entom Apr 5, 2019
02656ef
Merge remote-tracking branch 'origin/full-width-toast' into full-widt…
entom Apr 5, 2019
41c40e0
Merge branch 'master' into full-width-toast
entom Apr 5, 2019
a93bee6
Merge branch 'master' into full-width-toast
entom Apr 7, 2019
e5177a3
Merge branch 'master' into full-width-toast
entom Apr 8, 2019
8bb032f
Merge branch 'master' into full-width-toast
entom Apr 8, 2019
611f5c7
Merge branch 'master' into full-width-toast
entom Apr 11, 2019
0a43142
Merge branch 'master' into full-width-toast
entom Apr 11, 2019
5e13d42
Fix for last merge
entom Apr 11, 2019
d6f6427
Merge branch 'master' into full-width-toast
liamdebeasi Apr 16, 2019
51e0163
add left/right rtl test
liamdebeasi Apr 16, 2019
dfa08d9
rename left and right to start and end
liamdebeasi Apr 16, 2019
1b7a51c
update test name, run build
liamdebeasi Apr 16, 2019
42915eb
run build
liamdebeasi Apr 16, 2019
9b3f099
fix(toast): replace removed CSS from merge
brandyscarney Apr 16, 2019
f96ea93
style(test): remove extra spaces
brandyscarney Apr 16, 2019
0d7515d
fix(toast): use proper values for ios and md modes
brandyscarney Apr 16, 2019
6947c32
test(toast): remove spaces and line breaks
brandyscarney Apr 16, 2019
6d25504
fix(toast): style position on the main toast wrapper
brandyscarney Apr 16, 2019
da48555
style: add line break in props
brandyscarney Apr 16, 2019
ea4fbed
Merge branch 'master' into full-width-toast
brandyscarney Apr 16, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/api.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1166,10 +1166,12 @@ ion-toast,css-prop,--box-shadow
ion-toast,css-prop,--button-color
ion-toast,css-prop,--color
ion-toast,css-prop,--height
ion-toast,css-prop,--left
ion-toast,css-prop,--max-height
ion-toast,css-prop,--max-width
ion-toast,css-prop,--min-height
ion-toast,css-prop,--min-width
ion-toast,css-prop,--right
ion-toast,css-prop,--width

ion-toggle,shadow
Expand Down
2 changes: 2 additions & 0 deletions core/src/components/toast/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -272,10 +272,12 @@ Type: `Promise<void>`
| `--button-color` | Color of the button text |
| `--color` | Color of the toast text |
| `--height` | Height of the toast |
| `--left` | Position from left |
| `--max-height` | Maximum height of the toast |
| `--max-width` | Maximum width of the toast |
| `--min-height` | Minimum height of the toast |
| `--min-width` | Minimum width of the toast |
| `--right` | Position from right |
| `--width` | Width of the toast |


Expand Down
4 changes: 4 additions & 0 deletions core/src/components/toast/test/basic/e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ test('toast: custom class', async () => {
await testToast(DIRECTORY, '#custom-class-toast');
});

test('toast: left right position', async () => {
await testToast(DIRECTORY, '#toast-left-and-right');
});

/**
* RTL Tests
*/
Expand Down
Loading