Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(md): fix flicker when navigating back in MD mode on certain Android devices #19553

Merged
merged 1 commit into from Oct 7, 2019

Conversation

@liamdebeasi
Copy link
Member

commented Oct 4, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #19491

What is the new behavior?

  • The leaving view, when navigating back, has display: none applied to it at the end of the transition, ensuring that there is no flicker between when the animation is destroyed and when the view is removed from the DOM.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core label Oct 4, 2019
@liamdebeasi

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2019

Associated dev build: npm i @ionic/angular@4.11.0-dev.201910041827.7768ab2

@manucorporat

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

I would like to know why this is a problem now, we haven't seen flickering before. I think it's important to understand why this is needed now, not against this change if we understand the root of the problem.

@liamdebeasi liamdebeasi merged commit 19ee21a into master Oct 7, 2019
2 checks passed
2 checks passed
build Workflow: build
Details
screenshot Screenshot
Details
@liamdebeasi liamdebeasi deleted the md-flicker-fix branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.