Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update server icon #1259

Merged
merged 8 commits into from Mar 22, 2024
Merged

feat: update server icon #1259

merged 8 commits into from Mar 22, 2024

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Aug 22, 2023 •
edited

resolves #407

@liamdebeasi liamdebeasi changed the base branch from main to feature-7.2 August 22, 2023 15:25
@liamdebeasi liamdebeasi requested review from a team and brandyscarney and removed request for a team August 22, 2023 16:17
@mapsandapps
Copy link
Contributor

what's the distinction between this and the server icon?

Base automatically changed from feature-7.2 to main October 10, 2023 14:37
@liamdebeasi liamdebeasi changed the base branch from main to feature-7.3.0 March 13, 2024 22:05
@liamdebeasi liamdebeasi changed the base branch from feature-7.3.0 to feature-7.4 March 22, 2024 13:55
@liamdebeasi liamdebeasi changed the title feat: add database icons feat: update server icon Mar 22, 2024
mapsandapps
mapsandapps approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@mapsandapps mapsandapps left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised that the index.html file doesn't show the generated SVGs. 😕 The build output is correct for these icons, so feel free to merge.

@brandyscarney brandyscarney removed their request for review March 22, 2024 15:37
@liamdebeasi liamdebeasi merged commit b4ade9d into feature-7.4 Mar 22, 2024
6 checks passed
@liamdebeasi liamdebeasi deleted the icon-database branch March 22, 2024 20:24
@liamdebeasi liamdebeasi mentioned this pull request Mar 22, 2024
Closed
@phucle-hiptech phucle-hiptech mentioned this pull request May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandyscarney brandyscarney brandyscarney left review comments

@mapsandapps mapsandapps mapsandapps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liamdebeasi @mapsandapps @brandyscarney