Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add types for icon names #1269

Open
mikaelkaron opened this issue Aug 30, 2023 · 1 comment
Open

feat: add types for icon names #1269

mikaelkaron opened this issue Aug 30, 2023 · 1 comment
Labels
type: feature request A request to add new functionality

Comments

@mikaelkaron
Copy link

mikaelkaron commented Aug 30, 2023 •
edited

Describe Problem

it should be possible to type the name and icon props with available icon names

Describe Preferred Solution

name could be typed as:

type IconNames = 'accessibility' | 'accessibility-outline' | 'accessibility-sharp'...

icon could be typed as:

type IconSource = IconNames | (string & {})

You can find an explanation for the string & {} part on google

Describe Alternatives

No response

Additional Information

No response
@mikaelkaron mikaelkaron added the triage New issues label Aug 30, 2023
@amandaejohnston
Copy link
Contributor

amandaejohnston commented Aug 30, 2023 •
edited

Thank you for the request. I agree that this would be a valuable addition to Ionicons 👍 We may be able to auto-generate the type using the existing generated metadata.

@amandaejohnston amandaejohnston added the type: feature request A request to add new functionality label Aug 30, 2023
@ionitron-bot ionitron-bot bot removed the triage New issues label Aug 30, 2023
@amandaejohnston amandaejohnston mentioned this issue Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature request A request to add new functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikaelkaron @amandaejohnston