Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDN doesn't work #971

Closed
kwiat1990 opened this issue May 15, 2021 · 3 comments
Closed

CDN doesn't work #971

kwiat1990 opened this issue May 15, 2021 · 3 comments

Comments

@kwiat1990
Copy link

kwiat1990 commented May 15, 2021

Hi, I'm using Ionic Iocons via CDN for a few months now and in the last couple of days I noticed that the official CDN link (which is also pointed in the ionic documentation) doesn't work anymore: https://unpkg.com/ionicons@5.5.1/dist/ionicons.js gives me Cannot find "/dist/ionicons.js" in ionicons@5.5.1 and on my page I can see GET https://unpkg.com/ionicons@5.5.1/dist/ionicons.js net::ERR_ABORTED 404.

The v5.4.0 does work.

@calvintam236 calvintam236 mentioned this issue May 23, 2021
@lugark
Copy link

lugark commented Jun 1, 2021

It seems the last version available on unpkg is 5.4.0

@bastecklein
Copy link

Same issue. Seems like this would be an easy fix guys...

@liamdebeasi
Copy link
Contributor

Hi everyone,

This has been resolved via #982, and with Ionicons v5.5.2 the ionicons.js file should be working again.

Stencil 1 had a deprecated loader that, when used, automatically added module and nomodule script tags to your web page. In Stencil 2 that loader was removed in favor of adding the module and nomodule script tags manually.

Ionicons v5.5 updated its internals to Stencil 2 to better support the custom elements bundle functionality, but in doing so we lost the deprecated loader.

I re-added the deprecated loader so that there is no breaking change in Ionicons v5 functionality, but this loader will be removed in Ionicons v6.

I have updated the usage on the Ionicons website to show the new installation code that we recommend: https://ionic.io/ionicons/usage The installation code that was previously recommended will be supported for all of Ionicons v5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants