This repository has been archived by the owner on Sep 15, 2021. It is now read-only.
added tts plugin wrapper #1265
Merged
added tts plugin wrapper #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great; I'd say the only change you need to make is to not include the files from ./dist/* when committing; those are build files and merge conflicts are hell when those are changed outside a release. We'll automatically update the files in ./dist/ when we deploy. |
|
Thank you. Should I only commit the file under ./src/plugins/* ? |
|
Yes |
gortok
added a commit
that referenced
this pull request
Jul 6, 2016
* added method to src,mocks, and respective tests (#1218) * update localNotification.ctrl.js (#1213) i think, to be able to calculate "_60_seconds_from_now", the "now" value has to be a number, so I added the "getTime()" method * $cordovaAppRate sets callbacks correctly (onButtonClicked, onRateDialogShow) (#1209) * Wrapper for 3d touch plugin (#1155) * Add wrapper for 3d plugin * Fixed JSHint warnings for undefined variable * added iosOptions to $cordovaSpinnerDialog.show() (#1224) * added iosOptions to $cordovaSpinnerDialog.show() * added missing comma * added additional test for options in spinnerDialog.show() method * Updated appVersion mocks and added tests (#1231) * Issue #1228 - google analytics (#1247) * Add key param check * Tests fix * Tests fix * Added shareWithOptions, which was introduced in 5.1.0 (#1263) See https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin#using-the-share-sheet for usage details * added tts plugin wrapper (#1265) * added tts plugin wrapper * commit only tts.js * only commit plugin * Add serial plugin wrapper (#1274) * Add cordovaSerial plugin wrapper and unit tests * Update README with serial plugin * Add serial to jshint globals * added recents control plugin wrapper (#1264) * added recents control plugin * built added recents control plugin * added plugin to plugin list * added tts plugin wrapper * commit only tts.js * only commit plugin * only commit recents plugin * remove tts plugin * added plugin to list * added coma :|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.