Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events polyfill is not up to date with latest version of Node.js #8

Open
eamonnmg opened this issue Jul 30, 2020 · 2 comments
Open

Events polyfill is not up to date with latest version of Node.js #8

eamonnmg opened this issue Jul 30, 2020 · 2 comments

Comments

@eamonnmg
Copy link

eamonnmg commented Jul 30, 2020 •
edited
Loading

The events.js polyfill is not up to date with the latest Node.js

For example, the polyfill is missing the EventEmitter.prototype.off method. This was introduced to node in version 10.0.0 (see https://nodejs.org/dist/latest-v14.x/docs/api/events.html#events_emitter_off_eventname_listener)
@eamonnmg eamonnmg changed the title EventEmitter.prototype.off is undefined Update events polyfill to be consistent with latest version of Node.js Jul 30, 2020
@eamonnmg eamonnmg changed the title Update events polyfill to be consistent with latest version of Node.js Events polyfill is not consistent with latest version of Node.js Jul 30, 2020
@eamonnmg eamonnmg changed the title Events polyfill is not consistent with latest version of Node.js Events polyfill is not up to date with latest version of Node.js Jul 30, 2020
@SamBroner
Copy link

Running into this as well. Should be an easy fix as it's just an alias for removeListener. https://nodejs.org/api/events.html#events_emitter_off_eventname_listener

@SamBroner SamBroner mentioned this issue Nov 27, 2020
Open
OrKoN added a commit to GoogleChromeLabs/chromium-bidi that referenced this issue Nov 24, 2022
@OrKoN
Use mitt as the event emitter
987d173 
This replaces the outdated rollup polyfill[1]
by a 200 byte event emitter called mitt[2] that comes with
a wildcard event matching.

[1]: ionic-team/rollup-plugin-node-polyfills#8
[2]: https://github.com/developit/mitt
@OrKoN OrKoN mentioned this issue Nov 24, 2022
Merged
OrKoN added a commit to GoogleChromeLabs/chromium-bidi that referenced this issue Nov 24, 2022
@OrKoN
Use mitt as the event emitter
d245c17 
This replaces the outdated rollup polyfill[1]
by a 200 byte event emitter called mitt[2] that comes with
a wildcard event matching.

[1]: ionic-team/rollup-plugin-node-polyfills#8
[2]: https://github.com/developit/mitt
OrKoN added a commit to GoogleChromeLabs/chromium-bidi that referenced this issue Nov 25, 2022
@OrKoN
Use mitt as the event emitter
b5b47dd 
This replaces the outdated rollup polyfill[1]
by a 200 byte event emitter called mitt[2] that comes with
a wildcard event matching.

[1]: ionic-team/rollup-plugin-node-polyfills#8
[2]: https://github.com/developit/mitt
OrKoN added a commit to GoogleChromeLabs/chromium-bidi that referenced this issue Nov 25, 2022
@OrKoN
Use mitt as the event emitter (#324)
1b2338a 
This replaces the outdated rollup polyfill[1]
by a 200 byte event emitter called mitt[2] that comes with
a wildcard event matching.

[1]: ionic-team/rollup-plugin-node-polyfills#8
[2]: https://github.com/developit/mitt
@arch1995
Copy link

Running into this as well, Found missing events.rawListeners(eventName)
https://nodejs.org/api/events.html#emitterrawlistenerseventname

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eamonnmg @SamBroner @arch1995