Skip to content

Commit

Permalink
chore(ci): use node 16 (#1774)
Browse files Browse the repository at this point in the history
  • Loading branch information
liamdebeasi committed Apr 21, 2023
1 parent bea44d9 commit 5da4aa7
Showing 1 changed file with 37 additions and 4 deletions.
41 changes: 37 additions & 4 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:

- uses: actions/setup-node@v2
with:
node-version: 14
node-version: 16

- name: Build
run: |
Expand All @@ -42,7 +42,7 @@ jobs:
# the framework string. As a result "vue" will map
# to both "vue" and "vue-vite" apps. Similarly,
# "react" will map to both "react" and "react-vite" apps.
framework: ['vue', 'react', 'ionic-angular', 'ionic1']
framework: ['vue', 'react']

runs-on: ubuntu-latest
needs: build
Expand All @@ -58,7 +58,7 @@ jobs:

- uses: actions/setup-node@v2
with:
node-version: 14
node-version: 16
cache: npm
cache-dependency-path: |
build/${{ matrix.framework }}-*/ionic.starter.json
Expand All @@ -69,6 +69,39 @@ jobs:
npm install
rm -rf node_modules/@types
npm run starters:test -- --type=${{ matrix.framework }}
test-legacy:
strategy:
matrix:
framework: ['ionic-angular', 'ionic1']

runs-on: ubuntu-latest
needs: build

steps:
- uses: actions/checkout@v2

- uses: actions/download-artifact@v2
with:
name: build

- run: tar -xf build.tar

- uses: actions/setup-node@v2
with:
# Legacy starter apps do not support
# node 16+ which is why we have a separate job
node-version: 14
cache: npm
cache-dependency-path: |
build/${{ matrix.framework }}-*/ionic.starter.json
build/${{ matrix.framework }}-*/package.json
- name: Test ${{ matrix.framework }}
run: |
npm install
rm -rf node_modules/@types
npm run starters:test -- --type=${{ matrix.framework }}
deploy:
runs-on: ubuntu-latest
Expand All @@ -83,7 +116,7 @@ jobs:

- uses: actions/setup-node@v2
with:
node-version: 14
node-version: 16

- uses: actions/download-artifact@v2
with:
Expand Down

0 comments on commit 5da4aa7

Please sign in to comment.