New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): use node 16 #1774

Merged

liamdebeasi merged 2 commits into main from node-16

Apr 21, 2023

Contributor

liamdebeasi commented Apr 21, 2023 •

edited

Loading

A Vue/Vite dependency is using https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing which is not supported in the version of node that our GitHub Actions scripts use. This PR bumps the scripts to use node 16 which supports nullish coalescing.

However, legacy starter apps such as ionic-angular and ionic1 do not support node 16. As a result, this PR does two things:

Creates a legacy test step that runs node 14 for ionic-angular and ionic1 projects
Updates the non-legacy test step to run node 16 for modern projects.


          chore(): use node 16

ac6e3c7

liamdebeasi changed the title ~~chore(): use node 16~~ chore(ci): use node 16


          separate test steps

98596ae

liamdebeasi marked this pull request as ready for review

April 21, 2023 13:48

liamdebeasi merged commit 5da4aa7 into main

liamdebeasi deleted the node-16 branch

April 21, 2023 13:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment