fix(react): cleanup events if they are no longer passed as props #148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Say i have some (react) code like:
Then the event handler doesn’t get removed when
someCondition
is false.The current code for syncing props, only considers new props when adding/removing event handlers, and doesn’t remove handlers that existed in previous props but not in new props.
This PR modifies the
attachProps
util to callremoveEventListener
on any listener which is not part of the latest props.I had a little trouble writing a good test (read: not testing implementation details), since I think testing-library does not work well with web components. So I just followed the approach in other tests (inspecting
__events
) instead.I also attempted to fix the build, as the
file://
urls for the svelte output target were causing issues.