Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependabot): ignore @types/node #102

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Conversation

rwaskiewicz
Copy link
Member

@rwaskiewicz rwaskiewicz commented Aug 12, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): dependabot infra

What is the current behavior?

we get at least one PR a week to upgrade @types/node to a version we
don't support/develop with (yet)

GitHub Issue Number: N/A

What is the new behavior?

this commit configures dependabot to ignore @types/node version
updates for node 18. we currently do not develop for this plugin using
node 18, but get a pr from our friend dependabot at least once a week
to upgrade to a new patch version. until we're on node 18, prevent
dependabot from trying to upgrade this package

Does this introduce a breaking change?

  • Yes
  • No

Testing

N/A - although I followed the guidance in https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#ignore

Other information

this commit configures dependabot to ignore `@types/node` version
updates for node 18. we currently do not develop for this plugin using
node 18, but get a pr from our friend dependabot at least once a week
to upgrade to a new patch version. until we're on node 18, prevent
dependabot from trying to upgrade this package
@rwaskiewicz rwaskiewicz marked this pull request as ready for review August 12, 2022 12:57
@rwaskiewicz rwaskiewicz requested a review from a team August 12, 2022 12:57
Copy link
Member

@alicewriteswrongs alicewriteswrongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

Copy link
Member

@tanner-reits tanner-reits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 'ole dependabot being annoying 🙄

@rwaskiewicz rwaskiewicz merged commit e2ca290 into main Aug 23, 2022
@rwaskiewicz rwaskiewicz deleted the rwaskiewicz-patch-1 branch August 23, 2022 15:33
rwaskiewicz added a commit that referenced this pull request Aug 23, 2022
this commit is a follow up to #102, and adds v17 of `@types/node`
to the list of versions that are ignored. this is done as we do not
develop under v17 of node
rwaskiewicz added a commit that referenced this pull request Aug 23, 2022
this commit is a follow up to #102, and adds v17 of `@types/node`
to the list of versions that are ignored. this is done as we do not
develop under v17 of node
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants