Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(github): ignore node 17 from type updates #115

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

rwaskiewicz
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): CI

What is the current behavior?

Dependabot is (annoyingly) asking us to upgrade to @types/node@17

GitHub Issue Number: N/A

What is the new behavior?

this commit is a follow up to #102, and adds v17 of @types/node
to the list of versions that are ignored. this is done as we do not
develop under v17 of node

Does this introduce a breaking change?

  • Yes
  • No

Testing

N/A

Other information

this commit is a follow up to #102, and adds v17 of `@types/node`
to the list of versions that are ignored. this is done as we do not
develop under v17 of node
@rwaskiewicz rwaskiewicz marked this pull request as ready for review August 23, 2022 15:41
@rwaskiewicz rwaskiewicz requested a review from a team August 23, 2022 15:41
Copy link
Member

@tanner-reits tanner-reits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

Copy link
Member

@alicewriteswrongs alicewriteswrongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛔️🤖🆙⛔️

@rwaskiewicz rwaskiewicz merged commit 35d8ab4 into main Aug 23, 2022
@rwaskiewicz rwaskiewicz deleted the rwaskiewicz-patch-1 branch August 23, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants