Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(breaking_changes): port puppeteer 19 support to v2 site #942

Merged
merged 1 commit into from
Dec 6, 2022
Merged

docs(breaking_changes): port puppeteer 19 support to v2 site #942

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/docs/introduction/upgrading-to-stencil-three.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,12 +283,12 @@ Replace all instances of `addDestory` with `addDestroy` and all instances of `re
The functionality of these methods remains the same.

## End-to-End Testing
### Puppeteer v10 Required
### Puppeteer v10+ Required
Versions of Puppeteer prior to Puppeteer version 10 are no longer supported.
In newer versions of Puppeteer, the library provides its own types, making `@types/puppeteer` no longer necessary.
Ensure that Puppeteer v10 is installed, and that its typings are not:
Ensure that Puppeteer v10 or higher is installed, and that its typings are not:
```bash
$ npm install puppeteer@10
$ npm install puppeteer
$ npm uninstall @types/puppeteer
```

Expand Down