fix(next): fix styles hmr

ionic-team · Feb 26, 2020 · 9a015e9 · 9a015e9
1 parent cbeec64
commit 9a015e9
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/src/compiler_next/bundle/ext-transforms-plugin.ts b/src/compiler_next/bundle/ext-transforms-plugin.ts
@@ -58,12 +58,18 @@ export const extTransformsPlugin = (config: d.Config, compilerCtx: d.CompilerCtx
           this.error('Plugin CSS transform error');
         }
 
-        buildCtx.stylesUpdated.push({
-          styleTag: pathData.tag,
-          styleMode: pathData.mode,
-          styleText: cssTransformResults.styleText,
+        const hasUpdatedStyle = buildCtx.stylesUpdated.some(s => {
+          return s.styleTag === pathData.tag && s.styleMode === pathData.mode && s.styleText === cssTransformResults.styleText
         });
 
+        if (!hasUpdatedStyle) {
+          buildCtx.stylesUpdated.push({
+            styleTag: pathData.tag,
+            styleMode: pathData.mode,
+            styleText: cssTransformResults.styleText,
+          });
+        }
+
         return {
           code: cssTransformResults.code,
           map: cssTransformResults.map,

diff --git a/src/dev-server/hmr-client/hmr-inline-styles.ts b/src/dev-server/hmr-client/hmr-inline-styles.ts
@@ -32,7 +32,7 @@ export const hmrInlineStyles = (elm: Element, versionId: string, stylesUpdated:
 };
 
 const hmrStyleElement = (elm: Element, versionId: string, stylesUpdated: d.HmrStyleUpdate) => {
-  const styleId = elm.getAttribute('s-id');
+  const styleId = elm.getAttribute('sty-id');
   if (styleId === stylesUpdated.styleId && stylesUpdated.styleText) {
     // if we made it this far then it's a match!
     // update the new style text