-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Removing polyfills except for es5 builds breaks existing installs #5780
Comments
@gavmck thanks for raising the issue. Unfortunately I was not able to verify that exploding build 😉 I created a new Stencil project, build it with v4.14.0 and then again with v4.18.1 and everything was fine:
Can you provide a step by step description on how to reproduce the problem please? |
Thanks for the issue! This issue has been labeled as Please reproduce this issue in an Stencil starter component library and provide a way for us to access it (GitHub repo, StackBlitz, etc). Without a reliable code reproduction, it is unlikely we will be able to resolve the issue, leading to it being closed. If you have already provided a code snippet and are seeing this message, it is likely that the code snippet was not enough for our team to reproduce the issue. For a guide on how to create a good reproduction, see our Contributing Guide. |
@christian-bromann Ah sorry, it's not the build that explodes, it's the install. The previous instructions said to do this.
Now the |
The type also seems to output that the function exists still
|
How do you set |
I'll see if I can know one up. It looks like it was removed from the docs last year and I missed it. |
That is correct. This has been done due to the fact that Stencil stopped supporting IE, afaik. Do you think we can close this issue then? |
Do we still need to update the type? |
Yes, let me raise a PR for that. |
Actually we have this planned to remove for Stencil v5. |
We have a polyfill problem in our repos with v4.18.1. We have one repo for Stencil that generates the Web components, and another repo that consumes that repo to generate the React components. Any project that attempts to use the React components gets the following error: |
@Kwooda thanks for the feedback, is there a chance you can provide a minimal reproducible example? |
I don't know - last time I tried I got slapped by our security team, but I'll see if there's anything I can do. |
Ideally from a new Stencil project, e.g. that you can create via |
If I keep the same structure described in Stencil documentation to generate wrappers of Vue Components and React Components, we have a problem with Stencil 4.18.x to render these components You can check my real code here And I have a workaround to work with Vue3 too In both cases I receive an error because ![]() Can you help us? |
@felipefialho The answer for us was just to remove all mention of applyPolyfills |
Apply polyfills apparently got removed as IE is no longer supported: ionic-team/stencil#5780. No need to keep it around anymore.
I'm a little bit confused why was this PR (#5725) part of an v4 minor/patch release, for me it looks like a breaking change and should be done in v5. stencil/src/compiler/output-targets/dist-lazy/generate-esm.ts Lines 61 to 63 in 47c8efc
|
Prerequisites
Stencil Version
4.18.1
Current Behavior
The PR to remove polyfills unless explicitly building es5 means that, although
addPolyfills
is still defined as being exported in the types, the function does not exist. This meant when we our package lock updated from 4.14.x to 4.18.1, the install broke.PR #5725
Expected Behavior
Might be cleaner to keep exporting the function, but make it do nothing so the import doesn't explode before removing in the next major.
System Info
No response
Steps to Reproduce
Install stencil 4.14.x and use applyPolyfills.
Update to stencil 4.18.1, watch build explode.
Code Reproduction URL
https://sorry.dont/have/this.biz
Additional Information
No response
The text was updated successfully, but these errors were encountered: