chore(typings): update browser-compile typings #3259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit is a quick fix for the browser-compile tests that currently do not compile after setting `useUnknownInCatchVariables` in #3211. This went unnoticed as this application is not currently type checked by our CI process. In order to get the application to compile, we type the error as `any` for now, with the intent of properly narrowing it in STENCIL-371 (and adding proper CI checks there as well). this commit only unblocks next monday's release.
ltm
approved these changes
Mar 2, 2022
14 tasks
rwaskiewicz
added a commit
that referenced
this pull request
Mar 11, 2022
this commit introduces proper type guards for the browser-compile project, removing the stopgap 'any' usage that was introduced in #3259
14 tasks
rwaskiewicz
added a commit
that referenced
this pull request
Mar 15, 2022
this commit introduces proper type guards for the browser-compile project, removing the stopgap 'any' usage that was introduced in #3259
rwaskiewicz
added a commit
that referenced
this pull request
Mar 24, 2022
this commit introduces proper type guards for the browser-compile project, removing the stopgap 'any' usage that was introduced in #3259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run test.karma.prod) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Preflight checklists for releasing Stencil can't be followed, as there are typescript errors outside the core compiler - specifically as a part of a manual testing suite.
GitHub Issue Number: N/A
What is the new behavior?
this commit is a quick fix for the browser-compile tests that currently
do not compile after setting
useUnknownInCatchVariablesin#3211. This went unnoticed as
this application is not currently type checked by our CI process. In
order to get the application to compile, we type the error as
anyfornow, with the intent of properly narrowing it in STENCIL-371 (and adding
proper CI checks there as well). this commit only unblocks next monday's
release.
Does this introduce a breaking change?
Testing
Checkout this branch, and build Stencil:
npm ci && npm run build:Start the browser-compile project -
cd test/browser-compile && npm run startOther information
I intend to really fix this in a future ticket, this is just to unblock next Monday's release