chore(ci): wire test/ to ci #3263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwaskiewicz
commented
Mar 3, 2022
| "analysis": "node ./.scripts/analysis.js", | ||
| "build": "npm run build.hello-world && npm run build.hello-vdom && npm run build.todo && npm run build.end-to-end && npm run build.ionic && npm run analysis", | ||
| "TODO-STENCIL-389": "echo Remove the exit call below", | ||
| "analysis": "exit 0 && node ./.scripts/analysis.js", |
There was a problem hiding this comment.
This command can have exit 0 here as it's run in a subshell, and therefore don't cause premature ending of the parent script.
This script hasn't been run since Stencil v1.9, which is why I want to take the time to really understand
what it's doing (it writes the README file in this test dir) so that we can understand changes in file size & count
this commit adds building most projects in the `test/` dir to stencil's ci system. the `test/package.json` is updated to include the `browser-compile` subdir, as well as a few script renames. those script names are propagated up to the project's root level `package.json` so that they may be called one of two ways: 1. in ci via `test.analysis` 2. locally as a part of the 'test all' script, `test.prod`
rwaskiewicz
force-pushed
the
rwaskiewicz/add-ci-checks-browser-compile
branch
from
fbe16af
to
97fe0a8
Compare
- add a `package-lock.json` to allow for `npm ci` installs in ci - remove `exit 0` call in `test/package.json` to allow for running build
- add a `package-lock.json` to allow for `npm ci` runs in ci - this required updating the ionic app's `.npmrc` and `.gitignore` - update the app to use ionic v6 - remove `exit 0` call from `package.json` in test dir
rwaskiewicz
changed the title
ltm
approved these changes
Mar 7, 2022
| package-lock=true |
There was a problem hiding this comment.
Eventually we should just delete the .npmrcs.
There was a problem hiding this comment.
Agreed - for posterity (aka future me), the reason we kept them was that there is a test/.npmrc file that has package-lock=false in it. To keep the number of changes minimal, we overrode the value in the subdirectory to avoid side effects on other projects
rwaskiewicz
added a commit
that referenced
this pull request
Jan 24, 2023
this commit updates the typings for the analysis task. the team re-enabled these tasks/tests (for the most part) in #3263. at the same time, a commit that updates typings for onInput events was sitting in the v3.0.0-dev branch, #3135 upon merging main into v3.0.0-dev, the build broke. this commit fixes the typings to align with the latter commit.
rwaskiewicz
added a commit
that referenced
this pull request
Jan 25, 2023
this commit updates the typings for the analysis task. the team re-enabled these tasks/tests (for the most part) in #3263. at the same time, a commit that updates typings for onInput events was sitting in the v3.0.0-dev branch, #3135 upon merging main into v3.0.0-dev, the build broke. this commit fixes the typings to align with the latter commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passed (npm test.prodwas run)npm run test.karma.prod) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Projects under the
test/directory aren't type checked, which led to requiring a quickfix of #3259 to unblock Monday's release. We should
have caught this in #3211, but CI wasn't hooked up here
GitHub Issue Number: N/A
What is the new behavior?
this commit adds building several applications in the test/ directory to
the project's root level
test.prodnpm script. while wiring these up,it was determined there are two projects in test/ that do not compile.
fixing these at a high level have been included in two separate commits in this
PR.
Does this introduce a breaking change?
Testing
I've broken CI intentionally (and unintentionally 馃槅) a few times getting the todo and ionic apps to build, as well
as verifying that a broken
browser-compileapp will also fail CI