Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): don't break HMR by mangling CSS #3517

Merged
merged 8 commits into from
Aug 15, 2022
Merged

fix(compiler): don't break HMR by mangling CSS #3517

merged 8 commits into from
Aug 15, 2022

Commits on Aug 15, 2022

  1. fix(compiler): don't break livereload by mangling CSS 

    This fixes an issue (#3461) where CSS is being inappropriately mangled
when using the hot-reload dev server. The issue has details about
exactly what the problem is, but basically in short if you are using the
`dist-hydrate-script` output target and running the dev server then any
change to a CSS file will cause all styling to be wiped from the related
component in the browser, making for a pretty inadequate developer
experience.

This commit fixes the issue by changing the conditions under which
original CSS selectors are commented out and 'scoped' so that it is only
done when you are have `scoped: true` set on a component (I believe this
was the original intent but for some reason the code wasn't set up to do
this).
    @alicewriteswrongs
    alicewriteswrongs committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    ea909ef View commit details
    Browse the repository at this point in the history

  2. propagate ValidatedConfig to fix some strictNullChecks errors

    @alicewriteswrongs
    alicewriteswrongs committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    cb5591f View commit details
    Browse the repository at this point in the history

  3. prettier

    @alicewriteswrongs
    alicewriteswrongs committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    0209d12 View commit details
    Browse the repository at this point in the history

  4. trying to make this test work cross platform

    @alicewriteswrongs
    alicewriteswrongs committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    42d65ec View commit details
    Browse the repository at this point in the history

  5. feedback, and change the fix for HMR issue

    @alicewriteswrongs
    alicewriteswrongs committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    b92e451 View commit details
    Browse the repository at this point in the history

  6. expand tests a bit to cover the changes

    @alicewriteswrongs
    alicewriteswrongs committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    8aecab4 View commit details
    Browse the repository at this point in the history

  7. prettier

    @alicewriteswrongs
    alicewriteswrongs committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    964efa9 View commit details
    Browse the repository at this point in the history

  8. fmt

    @alicewriteswrongs
    alicewriteswrongs committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    cc663cd View commit details
    Browse the repository at this point in the history