forked from cwoolum/ionicV4-tslint
-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(rules): add ion-menu-toggle-is-now-an-element rule
- Loading branch information
Showing
3 changed files
with
88 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
import { createDirectiveToElementRuleClass } from './helpers/directiveToElement'; | ||
|
||
const directive = 'menuToggle'; | ||
|
||
export const ruleName = 'ion-menu-toggle-is-now-an-element'; | ||
export const Rule = createDirectiveToElementRuleClass(ruleName, directive, 'ion-menu-toggle'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
import { ruleName } from '../src/ionMenuToggleIsNowAnElementRule'; | ||
import { assertAnnotated, assertSuccess } from './testHelper'; | ||
|
||
describe(ruleName, () => { | ||
describe('success', () => { | ||
it('should work with proper style', () => { | ||
let source = ` | ||
@Component({ | ||
template: \` | ||
<ion-menu-toggle> | ||
<ion-button> | ||
Toggle Menu | ||
</ion-button> | ||
</ion-menu-toggle> | ||
\` | ||
}) | ||
class Bar{} | ||
`; | ||
assertSuccess(ruleName, source); | ||
}); | ||
}); | ||
|
||
describe('failure', () => { | ||
it('should fail when menuToggle attribute is used on button', () => { | ||
let source = ` | ||
@Component({ | ||
template: \` | ||
<button ion-button menuToggle>Toggle Menu</button>\` | ||
~~~~~~~~~~ | ||
}) | ||
class Bar{} | ||
`; | ||
|
||
assertAnnotated({ | ||
ruleName, | ||
message: 'menuToggle is now an ion-menu-toggle element instead of an Angular directive.', | ||
source | ||
}); | ||
}); | ||
|
||
it('should fail when menuToggle attribute is used on anchor', () => { | ||
let source = ` | ||
@Component({ | ||
template: \` | ||
<a ion-button menuToggle (click)="doSomething()">Toggle Menu</a>\` | ||
~~~~~~~~~~ | ||
}) | ||
class Bar{} | ||
`; | ||
|
||
assertAnnotated({ | ||
ruleName, | ||
message: 'menuToggle is now an ion-menu-toggle element instead of an Angular directive.', | ||
source | ||
}); | ||
}); | ||
|
||
it('should fail when ion-button attribute is used with multiline', () => { | ||
let source = ` | ||
@Component({ | ||
template: \` | ||
<a | ||
ion-button | ||
menuToggle | ||
~~~~~~~~~~ | ||
(click)="doSomething()">Toggle Menu</a>\` | ||
}) | ||
class Bar{} | ||
`; | ||
|
||
assertAnnotated({ | ||
ruleName, | ||
message: 'menuToggle is now an ion-menu-toggle element instead of an Angular directive.', | ||
source | ||
}); | ||
}); | ||
}); | ||
}); |