Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo page has a flexbox height bug in Safari 9.x (OS X, iOS) #6

Closed
opattison opened this issue Dec 11, 2015 · 5 comments
Closed

Demo page has a flexbox height bug in Safari 9.x (OS X, iOS) #6

opattison opened this issue Dec 11, 2015 · 5 comments
Labels

Comments

@opattison
Copy link
Contributor

2015-12-11 flex-basis bug in Safari – collapsed vertical height

Spotted in Safari OS X 9.0.1 on OS X. On narrower views (below 48em, I believe), the grid collapses vertically, creating a visual bug. This is caused by how Safari handles flex: 0 0 100%. Setting this to flex: 0 0 auto should fix this behavior, but more cross-browser testing is needed since Chrome, Firefox and others may treat this differently (although I believe my fix should work, so do test it out). flex-basis: 100% is the issue here. Note that 100% works for horizontal (row) but fails for vertical (column) flex layouts in Safari. auto (the default value for flex-basis) negates the issue for either flex-direction.

I have run into this issue on multiple other sites. I've looked at the spec and I'm not yet entirely sure whether Safari has it right or wrong.

Let me know if you want more testing or a PR.

@IonicaBizau
Copy link
Owner

That's a nice catch, @opattison! ✨
Yes, test it on other browsers and if it works, would be happy to accept a pull request regarding this fix! 😄

It's funny that 100% and auto have same length, so, the size will not be modified. 😁

@opattison
Copy link
Contributor Author

I believe this is a currently unresolved flex bug in Safari. I have a really brief fix that will address the issue – making a PR now. I hope this solution will work. I think it is necessary to support iOS and OS X Safari users, which is a pretty big target.

@opattison
Copy link
Contributor Author

IE 11 failed with this flex bug in exactly the same way – my fix in #8 addresses both equally.

@IonicaBizau IonicaBizau mentioned this issue Dec 14, 2015
@IonicaBizau
Copy link
Owner

Fixed in 1.2.0, thanks to you! 👍 👏

@tavax
Copy link

tavax commented May 2, 2017

Allways not working on Safari OSX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants