-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demo page has a flexbox height bug in Safari 9.x (OS X, iOS) #6
Comments
That's a nice catch, @opattison! ✨ It's funny that |
I believe this is a currently unresolved flex bug in Safari. I have a really brief fix that will address the issue – making a PR now. I hope this solution will work. I think it is necessary to support iOS and OS X Safari users, which is a pretty big target. |
IE 11 failed with this flex bug in exactly the same way – my fix in #8 addresses both equally. |
Fixed in |
Allways not working on Safari OSX |
Spotted in Safari OS X 9.0.1 on OS X. On narrower views (below 48em, I believe), the grid collapses vertically, creating a visual bug. This is caused by how Safari handles
flex: 0 0 100%
. Setting this toflex: 0 0 auto
should fix this behavior, but more cross-browser testing is needed since Chrome, Firefox and others may treat this differently (although I believe my fix should work, so do test it out).flex-basis: 100%
is the issue here. Note that100%
works for horizontal (row
) but fails for vertical (column
) flex layouts in Safari.auto
(the default value forflex-basis
) negates the issue for eitherflex-direction
.I have run into this issue on multiple other sites. I've looked at the spec and I'm not yet entirely sure whether Safari has it right or wrong.
Let me know if you want more testing or a PR.
The text was updated successfully, but these errors were encountered: