Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New versions of Fantomas require trivia to have some value #44

Open
UnoSD opened this issue Aug 10, 2022 · 0 comments
Open

New versions of Fantomas require trivia to have some value #44

UnoSD opened this issue Aug 10, 2022 · 0 comments

Comments

@UnoSD
Copy link

UnoSD commented Aug 10, 2022

Is your feature request related to a problem? Please describe.
After updating Myriad (and consequently Fantomas), all the generated code misses keywords, turns out new Fantomas versions require a non-None value for trivia, but most of the helpers generate it with None, causing all the generated AST to produce nonsense code.

Describe the solution you'd like
Can all the default record and helper methods generate trivia with Some Range.Zero by default?

Describe alternatives you've considered
Dropping FsAst and re-writing all the code to create unions directly
Cloning the repository and making the changes myself and reference locally

Additional context
Please see here: MoiraeSoftware/myriad#154
Started playing with it here: a6649ec

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant