WIP: Unify projects and misc cleanups. #307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We detect the indentation size and position in order to remove meaningless spaces. We also add support for the same tags as in Ionide formatting process. Added tag: - remarks - typeparam
* add new vs2017 f# binary paths and probe them first * add msbuild probing changes, and add 10.1 to the list of legacy f# version probes * comments explaining locations * remove unclear comments * try to fix travis build on netcore by specifying frameworkpathoverride
… returned for the full-framework FSAC host (ionide#305)
…iles/dependencies as necessary
|
Closes #284 |
|
something fishy is up with the builds, I get similar errors for all my PRs. we should probably have a come-to-jesus/refactor around the CI situation for this repo. |
| @@ -20,6 +20,7 @@ | |||
| ] | |||
| } | |||
| } | |||
| [Debug] TryGetCompletions took 122.916000ms | |||
There was a problem hiding this comment.
This probably should be filtered out since it will always break the tooling.
| @@ -1,14 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
not restored test has been really problematic for a while, I'd be OK with just removing it
Krzysztof-Cieslak
force-pushed
the
fcs_20180726
branch
from
69e9b1d
to
7abd420
Compare
Closed
Closed
|
There have been large changes in the repo since then, I'll close this effort so as to not discourage others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two commits fix up some usage of ConcurrentDictionary (direct indexing is bad, mmkayyy?) and use a verbosity parameter when the project cracker supports it.
The third one is a bit of WIP that might be useful for chaining Async cancellations.
4-7 are the big deal: unifying the net/netcore versions of the project into a shared set of project files.
References are conditionally included, thanks to paket's groups and framework scoping, and defines are conditionally-enabled as well.