Ugrid2 dev #12
Merged
Ugrid2 dev #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
daltonkell
commented
Nov 29, 2018
daltonkell
commented
Rearranged the checks.md for clarity. Re-wrote first four core checks to make logic easier to follow, more elegant. Next step is writing the tests for these re-written checks and then finishing more complex checks and their tests.
…iance-checker command line tool. Previous commit had the initialization of the UgridChecker10 object requiring a dataset, which broke the compliance checker. Now it leverages the BaseNCCheck.setup() method to assign the dataset object and create the dictionary of meshes. Also had to add _cc_display_headers. Edited the checks.md for better organization and added an omitted check for volume_shape_type. The ugrid.cdl includes a second mesh variable of dimension 2; 3D checks have yet to be implemented and tested.
Checks.md now use the latest names of the checks; features consolidated information and updated format.
After creating a dependency graph for the feature checks, the checker has been re-written to run more efficiently and with more logical, readable steps. 1-D and 2-D meshes are checked for their features, while development for fully unstructured, 3D meshes is needed. The checks also come complete with tests. Other changes are as follows: - renamed UgridChecker10 to UgridChecker - renamed test file - updated checks.md - updated ugrid.cdl test file - edited setup.py accordingly
A conflict during the TravisCI build with an earlier PR prompted changing of the netCDF4 requirement in the requirements file from v.1.4.2 to a more relaxed >=v.1.4.0. Versions prior to 1.4.2 do not have a Variable.get_dims() method, so in order to keep the code functioning we now get the dimensions in a slightly more verbose way.
|
This also addresses #6 (closing that issue). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.